Merge branch 'main' into feat/pm-agent-registry-pull-secret
This commit is contained in:
commit
553d027f7c
17 files changed
+888
-51
No files matched your search
@@ -0,0 +1,108 @@
|
||||
---
|
||||
date: 2026-10-30
|
||||
branch: fix/renovate-auth
|
||||
title: Renovate's token needs five scopes, not three; the workflow documented the wrong list, and now probes it
|
||||
---
|
||||
|
||||
## What changed
|
||||
|
||||
**The fix is operator-side.** `RENOVATE_TOKEN` lacks `read:organization`, and it will next lack
|
||||
`write:issue`. The operator must re-mint it with five scopes:
|
||||
|
||||
- `read:user`
|
||||
- `read:organization`
|
||||
- `write:repository`
|
||||
- `write:issue`
|
||||
- `read:package`
|
||||
|
||||
The git half fixes the two things that sent the operator round this loop twice.
|
||||
|
||||
**`.gitea/workflows/renovate.yaml`**:
|
||||
- **The header's scope list is corrected**, with the call each scope serves. The old list named
|
||||
only `write:repository`, `read:user` and `read:package`, and the operator minted exactly that.
|
||||
The preflight's "TO FIX" text is corrected the same way.
|
||||
- **A new step, "Preflight - the token has every scope Renovate needs".**
|
||||
- It probes read-only GETs: `/user` for read:user, `/orgs/Home-Network` for read:organization,
|
||||
`/repos/{repo}` for read:repository, `/repos/{repo}/labels` for read:issue, and registry
|
||||
`/v2/token` for read:package.
|
||||
- It reads the token's own scope list out of Gitea's 403 from `/admin/orgs` (names only), and
|
||||
requires `write:repository` and `write:issue` in it.
|
||||
- It says what a failure means: 401 is the value; a Gitea 403 is a scope, and the probe prints
|
||||
Gitea's message; an "Access denied" 403 is a Cilium/Envoy denial.
|
||||
- The token is fed to curl on stdin (`--config -`), never in argv.
|
||||
|
||||
**`ci/lint.sh`**: a new guard rejects any non-comment `uses:` in `.gitea/workflows` that needs a
|
||||
Docker daemon: `docker://`, `renovatebot/github-action` and Docker's daemon-bound
|
||||
`docker/*-action`s. That is the class of bug fixed in #84.
|
||||
|
||||
### Root cause, with evidence
|
||||
|
||||
Run 350 (task 567, 06:49 UTC) **got further than 348 and 349.** Gitea's router log, filtered to
|
||||
the act-runner pod `10.0.0.38`:
|
||||
|
||||
06:49:31 GET /api/v1/user 200 OK
|
||||
06:49:31 GET /api/v1/version 200 OK
|
||||
06:49:31 GET /api/v1/repos/Home-Network/home-network-k3s-impl 200 OK
|
||||
06:49:31 GET /api/v1/orgs/Home-Network 403 Forbidden
|
||||
|
||||
There were no `/v2/` requests: Renovate stopped before extraction. From the job log, verbatim:
|
||||
|
||||
ERROR: Repository has unknown error (repository=Home-Network/home-network-k3s-impl)
|
||||
"url": "https://gitea.home.keithjackson.dev/api/v1/orgs/Home-Network",
|
||||
"message": "token does not have at least one of required scope(s), required=[read:organization], token scope=read:package,write:repository,read:user"
|
||||
"x-envoy-upstream-service-time": "27", "server": "envoy"
|
||||
INFO: Repository finished ... "result": "unknown-error", "exitCode": 8
|
||||
|
||||
**This is not Cilium.** The body is Gitea's JSON scope message, Gitea logged the request, and
|
||||
`x-envoy-upstream-service-time` shows that Envoy forwarded it upstream.
|
||||
|
||||
**The secret WAS updated.** Runs 348 and 349 got `GET /user 403` from `tokenRequiresScopes`. Run 350
|
||||
got `/user 200`, and its token scope list now includes `read:user`.
|
||||
|
||||
**Why `read:organization` is needed.** Renovate 44.167.0, `lib/modules/platform/gitea/index.ts`
|
||||
`initRepo`, calls `helper.isOrg` → `GET /orgs/{owner}` and rethrows on error. Gitea 1.24.3,
|
||||
`routers/api/v1/api.go`, puts `/orgs/{org}` behind
|
||||
`tokenRequiresScopes(AccessTokenScopeCategoryOrganization)`.
|
||||
|
||||
**Why `write:issue` is needed next.** In the same `api.go`, `/repos/{o}/{r}/issues…`, `/labels`
|
||||
and `/milestones` sit in a group with `tokenRequiresScopes(AccessTokenScopeCategoryIssue)`
|
||||
(lines 1466–1582). Renovate's gitea-helper uses `/issues`, `/issues/{n}/labels`, `/labels` and
|
||||
`/issues/{n}/comments`, for the dependency dashboard (`:dependencyDashboard` is extended) and for
|
||||
PR labels. A dry run only reads them; a scheduled run writes them.
|
||||
|
||||
The other causes the coordinator listed are ruled out:
|
||||
- **Schedule window and dry-run.** The run never reached branch processing.
|
||||
- **Repository config.** The run never reached the clone (`"cloned": undefined`).
|
||||
- **The Summary step.** It is not involved; the failure is Renovate's own exit 8.
|
||||
|
||||
## What I verified
|
||||
|
||||
- I read the whole run 350 job log (204 lines), and the router lines above. Runs 348 and 349 are
|
||||
as recorded in `decisions/2026-10-30-renovate-first-run.md`'s follow-up: `/user` got 403 from
|
||||
`tokenRequiresScopes`.
|
||||
- **The probe step, in the pinned image.** I extracted the step body from the YAML and ran it in
|
||||
`ghcr.io/renovatebot/renovate:44.167.0` (`curl` 8.5.0 and `jq` are present) with a deliberately
|
||||
**bogus** token. Every probe reported 401 with the "token VALUE" diagnosis, the scope-list read
|
||||
fell back to a warning, and the step exited 1.
|
||||
- **The scope-list parser.** Against run 350's exact message format it reports `write:issue`
|
||||
MISSING. Against a five-scope list it reports both OK. Against `all` it reports both OK.
|
||||
- **The lint guard.** It flags `renovatebot/github-action` in the pre-#84 `renovate.yaml`
|
||||
(dfc432c, line 152). It reports nothing on the current workflows, and it ignores commented
|
||||
lines. `bash -n ci/lint.sh` passes.
|
||||
- **Account facts, read-only.** `renovate-bot` is a collaborator with `write`, and the org is
|
||||
public.
|
||||
|
||||
## What I did NOT verify
|
||||
|
||||
- **The probe with a real token. UNVERIFIED.** I never had the token. In particular, I have not
|
||||
observed that `GET /api/v1/admin/orgs` gives renovate-bot's token a 403 with a `token scope=`
|
||||
list. The source says the scope check runs before `reqSiteAdmin`. If the message format
|
||||
differs, the step warns and does not fail.
|
||||
- **That five scopes are enough for a full non-dry run.** They cover every helper endpoint Renovate
|
||||
44.167.0 calls, mapped to Gitea 1.24.3's route categories by reading source. Branch pushes go
|
||||
over git-over-HTTPS with the token; I believe that needs write:repository, but I have not
|
||||
observed it.
|
||||
- **Registry reads as renovate-bot.** `read:package` on a public org is expected to work. The new
|
||||
probe is the first real test of it.
|
||||
- **Sensitive paths.** `.gitea/**` and `ci/**` are both sensitive. CI's `approval-policy` will block
|
||||
until the operator posts `/approve-override` as a PR review.
|
||||
@@ -0,0 +1,113 @@
|
||||
---
|
||||
date: 2026-10-30
|
||||
branch: fix/renovate-first-run
|
||||
title: Renovate never started because its action needs a Docker daemon jobs here do not get; it now runs as the job container
|
||||
---
|
||||
|
||||
## What changed
|
||||
|
||||
**`.gitea/workflows/renovate.yaml`**: the job no longer uses `renovatebot/github-action`. The
|
||||
pinned Renovate image (`ghcr.io/renovatebot/renovate:44.167.0`, the same version the action was
|
||||
pinned to) is now the job's `container:`. A `run:` step calls `renovate-entrypoint.sh renovate`
|
||||
inside it. `actions/checkout` is gone, because Renovate clones the repo itself.
|
||||
`GITHUB_COM_TOKEN` is wired from a new **optional** secret, `RENOVATE_GITHUB_COM_TOKEN`. The step
|
||||
unsets it, and `RENOVATE_DRY_RUN`, when they evaluate to the empty string. The preflight also
|
||||
prints `renovate --version`, which proves the step ran inside the pinned image.
|
||||
|
||||
**`renovate.json5`**: one comment now names `container.image` as the version pin, in place of
|
||||
`renovate-version`. The config itself is unchanged.
|
||||
|
||||
### Why: the root cause
|
||||
|
||||
Every run of the action died before Renovate started. That includes the operator's dispatch,
|
||||
run 343 (task 555, 2026-10-30 06:14 UTC), and the 11 scheduled runs before it (312–322). From
|
||||
run 343's log:
|
||||
|
||||
RENOVATE_TOKEN is present (value not printed).
|
||||
[command]/usr/bin/docker run --env LOG_LEVEL ... --env RENOVATE_TOKEN=*** --env RENOVATE_CONFIG_FILE=/github-action/renovate.json5 ...
|
||||
failed to connect to the docker API at unix:///var/run/docker.sock; check if the path is correct and if the daemon is running: dial unix /var/run/docker.sock: connect: no such file or directory
|
||||
Error: The process '/usr/bin/docker' failed with exit code 1
|
||||
|
||||
The action is only a wrapper around `docker run`. On this runner a job deliberately gets no
|
||||
Docker daemon (`decisions/2026-10-29-image-pipeline.md`): act_runner maps `docker_host` to `-` when
|
||||
`DOCKER_HOST` is `tcp://`, and the DinD daemon is privileged. So this was a
|
||||
platform-compatibility failure. The run never reached authentication, token scope, config or the
|
||||
network. **The re-minted token is not implicated, and nothing in this log can say whether its
|
||||
scopes are right.**
|
||||
|
||||
A job `container:` needs no daemon. act creates it through the runner's DinD the same way it
|
||||
creates the default `ubuntu-latest` image, then `exec`s each step inside it. I checked this
|
||||
against gitea/act v0.261.2:
|
||||
|
||||
- The job container's entrypoint is `/bin/sleep` (`run_context.go`). The Renovate image has
|
||||
`/usr/bin/sleep`.
|
||||
- The step command files are written `0o666` (`step.go`), so the image's uid 12021 can write
|
||||
`$GITHUB_STEP_SUMMARY`.
|
||||
- `HOME` comes from the image env.
|
||||
|
||||
## What I verified
|
||||
|
||||
- **The root cause.** I read all of run 343's job log (162 lines, job 0; job 1 is 404). It has one
|
||||
error, quoted above, and no Renovate output at all. Runs 312–322 are all `failure` from the
|
||||
`schedule` event.
|
||||
- **The config validates against the pinned tag.** `podman run ... ghcr.io/renovatebot/renovate:44.167.0
|
||||
renovate-config-validator /tmp/renovate.json5` printed `Config validated successfully`. It also
|
||||
printed the known migration diff for the top-level `docker` block.
|
||||
- **A dry run with the fix extracts and looks up dependencies.** This was a local reproduction. I
|
||||
made a clean snapshot of this branch's tracked files. I ran it in a podman container of the pinned
|
||||
image with entrypoint `/bin/sleep`, as the image's own uid 12021 with `HOME=/home/ubuntu`.
|
||||
Inside it I `exec`ed the workflow step's `run:` body, extracted verbatim from the YAML, with:
|
||||
- `RENOVATE_PLATFORM=local`, `RENOVATE_DRY_RUN=full` and `GITHUB_COM_TOKEN=` (empty, to
|
||||
exercise the unset);
|
||||
- a docker host rule for `gitea.home.keithjackson.dev` using the `gitea-admin` credential from
|
||||
`~/.git-credentials`, passed through env and never printed.
|
||||
|
||||
The run exited 0 and logged `Dependency extraction complete`:
|
||||
- flux 15 deps / 13 files
|
||||
- github-actions 24 / 4
|
||||
- kubernetes 131 / 67
|
||||
- kustomize 2 / 2
|
||||
- regex (both custom managers) 7 / 6
|
||||
- **total 179 deps / 92 files**
|
||||
|
||||
It found **42 updates**: 29 kubernetes, 6 flux, 2 kustomize, 1 github-actions and 4 regex
|
||||
`digest`. 7 of them are `major`.
|
||||
- **The `# renovate-digest:` lookups against the Gitea registry succeed.** All three
|
||||
`/v2/token?scope=repository:home-network/<img>:pull` requests succeeded, and so did
|
||||
`HEAD /v2/home-network/<img>/manifests/main`. They proposed `digest` updates for
|
||||
`conformance/versions.env`, `infra/agent/versions.env`, `platform/pm-agent/configmap.yaml` and
|
||||
`platform/pm-agent/deployment.yaml`, all of which carry the zero placeholder digest today. The
|
||||
`kubernetes` manager's copies of those images report `disabled`, which is the intended effect of
|
||||
the packageRule.
|
||||
- **The new pin is still maintained by Renovate.** The github-actions manager extracts
|
||||
`ghcr.io/renovatebot/renovate:44.167.0` from `renovate.yaml` as depType `container`, and proposes
|
||||
44.198.0.
|
||||
- **The `regex` vs `custom.regex` question from #73/#77 is closed.** Both custom managers produced
|
||||
dependencies.
|
||||
- **Missing GitHub token.** The local run logged `GitHub token is required for some dependencies`.
|
||||
That accounts for 17 deps skipped with `github-token-required`, which is why
|
||||
`RENOVATE_GITHUB_COM_TOKEN` is offered as an optional secret.
|
||||
|
||||
## What I did NOT verify
|
||||
|
||||
- **The workflow on the real runner. UNVERIFIED.** My reproduction ran with podman, not
|
||||
act_runner + DinD, and used `--platform=local`. The act behaviour (sleep entrypoint, `exec` as the
|
||||
image user, 0666 command files) comes from reading the gitea/act v0.261.2 source, not from a run.
|
||||
The first real evidence will be a `workflow_dispatch` after merge.
|
||||
- **The Gitea platform path and `RENOVATE_TOKEN`'s scopes. UNVERIFIED.** I have no access token, only
|
||||
the `gitea-admin` password, which Renovate's Gitea platform cannot use. So these were not
|
||||
exercised: platform init (`GET /user`, which needs `read:user`), repo clone, and the registry
|
||||
lookups using the **token** with `read:package` rather than a password.
|
||||
- **Behaviour inside the schedule window.** A dispatch outside 03:00–06:00 America/New_York
|
||||
(07:00–10:00 UTC during EDT) will extract and look up, but will log "not within schedule"
|
||||
instead of `DRY-RUN: Would create ...` lines. I did not change this.
|
||||
- **Renovate as uid 12021 doing artifact updates** (for example helm lockfiles) on a real,
|
||||
non-dry run. `--dry-run=full` does not run the tools.
|
||||
- **The self-bump.** Renovate will propose `ghcr.io/renovatebot/renovate` 44.167.0 → 44.198.0 as a
|
||||
minor, which the default rule auto-merges. `.gitea/**` is a sensitive path, so it will in fact
|
||||
wait for an administrator override. Nothing re-runs `renovate-config-validator` on that bump,
|
||||
and no gate check runs the validator.
|
||||
- **No alert for "Renovate red every day".** That gap is still open. This failure ran for 12 days
|
||||
without anyone noticing.
|
||||
- **Sensitive path.** `.gitea/**` is in `infra/gitea/approval-policy.json`, so CI's
|
||||
`approval-policy` stage will block until the operator posts `/approve-override` as a PR review.
|
||||
@@ -0,0 +1,52 @@
|
||||
---
|
||||
date: 2026-10-30
|
||||
branch: fix/renovate-hold-auth-and-self
|
||||
title: Operator decision — the oauth2-proxy sidecar and Renovate's own version never auto-merge
|
||||
---
|
||||
|
||||
## What changed
|
||||
|
||||
`renovate.json5` gains two packageRules. Both set `automerge: false` and `addLabels: ["needs-review"]`.
|
||||
They sit after the auto-merge rule, so they override it at every update type. Each rule's
|
||||
`description` carries the operator's reason.
|
||||
|
||||
1. **`quay.io/oauth2-proxy/oauth2-proxy`.** This is the single depName emitted for:
|
||||
- `catalog/render.py` `OAUTH2_PROXY_IMAGE` (custom regex manager);
|
||||
- the five rendered `apps/wave-*` sidecars;
|
||||
- `platform/crafty/deployment.yaml` (kubernetes manager).
|
||||
|
||||
**Reason:** since v7.13.0, oauth2-proxy validates refreshed OIDC sessions against the access
|
||||
token, not the id_token. Every sidecar sets `--cookie-refresh`, and that path is untested against
|
||||
this Keycloak: the platform oauth2-proxy runs v7.15.5 without `--cookie-refresh`.
|
||||
`render-golden` and `--selftest` pass on the bump, but both check rendered text, not the binary.
|
||||
2. **`ghcr.io/renovatebot/renovate`.** This is the job `container.image` in
|
||||
`.gitea/workflows/renovate.yaml`. The rule also lists `renovatebot/github-action`, so a
|
||||
reintroduction would be held too. It is not used anywhere today; `ci/lint.sh` rejects it.
|
||||
|
||||
**Reason:** nothing re-validates `renovate.json5` against the new version before it takes
|
||||
effect. The 39.x `CONFIG_VALIDATION` failure is the precedent.
|
||||
|
||||
## What I verified
|
||||
|
||||
- **The config validates on the pinned 44.167.0.** `renovate-config-validator` printed
|
||||
`Config validated successfully`. The migration diff is only the pre-existing top-level `docker`
|
||||
block.
|
||||
- **The flag change is exactly the intended one.** I used Renovate 44.167.0's own
|
||||
`resolveConfigPresets` and `applyPackageRules` to evaluate b4ff287's config and this branch's
|
||||
config against the same updates (the local dry run of the #86 config). Exactly **2 of 29**
|
||||
branch rows differ:
|
||||
- `ghcr.io-renovatebot-renovate-44.x`: `automerge=true labels=` → `automerge=false labels=needs-review`;
|
||||
- `quay.io-oauth2-proxy-oauth2-proxy-7.x`: the same change, and every upgrade in the branch
|
||||
resolves `false`, the `catalog/render.py` one included.
|
||||
|
||||
The other 27 rows are byte-identical.
|
||||
|
||||
## What I did NOT verify
|
||||
|
||||
- **The three GitHub-hosted branches** in run 357 (`pin-dependencies`, `kubevirt-cdi`,
|
||||
`intel-intel-device-plugins-for-kubernetes-0.x`) are not in the harness table: my local run has
|
||||
no github.com token. Neither rule's package names can match them.
|
||||
- **A live Renovate run with this config.** The next debug-level dispatch should show
|
||||
`needs-review` on both branches.
|
||||
- **The oauth2-proxy refresh path itself** remains untested. Exercising it on one app is the
|
||||
review the label asks for.
|
||||
@@ -0,0 +1,128 @@
|
||||
---
|
||||
date: 2026-10-30
|
||||
branch: fix/renovate-run-hygiene
|
||||
title: Renovate's first completed dry runs, audited; it would have opened red PRs for every app and missed the databases. Config fixed
|
||||
---
|
||||
|
||||
## What changed
|
||||
|
||||
**`renovate.json5` only.** Each change carries a comment quoting the measurement behind it.
|
||||
|
||||
1. **Three new regex managers, so updates edit the SOURCE.**
|
||||
- `catalog/*.yaml` `source.image`.
|
||||
- `catalog/render.py` `OAUTH2_PROXY_IMAGE`.
|
||||
- CNPG `imageName:` under `platform/` and `apps/`.
|
||||
|
||||
The first two match the rendered line's depName, so the catalog edit and the generated
|
||||
`apps/wave-*` edit land in **one** branch.
|
||||
2. **`allowedVersions` mirroring each ServiceDefinition's `update.range`:**
|
||||
- gitea/gitea `<2.0.0`
|
||||
- nextcloud `<32.0.0`
|
||||
- qbittorrent `<6.0.0`
|
||||
- radarr `<6.0.0`
|
||||
- sonarr `<5.0.0`
|
||||
- semaphore `<3.0.0`
|
||||
|
||||
Plus CNPG postgresql `<17.0.0`, because a Postgres major is a migration, not a bump.
|
||||
3. **The blast-radius never-automerge list gains** `gitea/gitea`, `gitea/act_runner` and
|
||||
`ghcr.io/cloudnative-pg/postgresql`.
|
||||
4. **HelmRelease range widening** (`matchManagers: flux`, ranged currentValue) is never
|
||||
auto-merged and is labelled `range-widen`.
|
||||
5. **Majors need a Dependency Dashboard tick** (`dependencyDashboardApproval`) before a PR opens.
|
||||
6. **`flux` manager docker deps are disabled.** These are duplicates of `kubernetes` manager
|
||||
extractions.
|
||||
7. **`velero/velero-plugin-for-aws` uses `semver` versioning**, so its RC pin can reach a stable
|
||||
release.
|
||||
8. **`python` minors are not auto-merged.**
|
||||
9. **Two false comments are corrected.**
|
||||
- Ranges "cap Renovate at patches": false, Renovate widens them.
|
||||
- `nextcloud:31-apache` and `docker:27-dind` "cannot be maintained": false, they were.
|
||||
|
||||
PR #85 is merged, so nothing here overlaps an open branch.
|
||||
|
||||
### The audit: dispatch runs 353 (07:12 UTC) and 354 (07:23 UTC), on 593d0fa
|
||||
|
||||
Both runs ended `success`, Renovate `"result": "done"`, `exitCode 0`. Both were at `info` level, so
|
||||
I reproduced the per-dependency detail with a debug-level local dry run of the same commit (see
|
||||
below).
|
||||
|
||||
The runs were inside the 03:00–06:00 America/New_York window, so branches were processed:
|
||||
- run 353: 37 "Would commit" branches;
|
||||
- run 354: 40, because the operator had added `RENOVATE_GITHUB_COM_TOKEN` 9 s before it.
|
||||
|
||||
Gitea's router log for the act-runner pod during both runs shows 317 2xx responses. The only
|
||||
non-2xx were all expected:
|
||||
- `/v2/` 401: the registry challenge;
|
||||
- `/admin/orgs` 403: the #85 scope probe, by design;
|
||||
- 6× `HEAD …/manifests/sha256:000…` 404: the placeholder digests.
|
||||
|
||||
| # | Class | Count | Cause | Severity | Fix |
|
||||
|---|---|---|---|---|---|
|
||||
| 1 | App-image PRs edit only generated `apps/wave-*` | 9 branches | A ServiceDefinition has no `apiVersion`, so the `kubernetes` manager extracts 0 deps from `catalog/`. The oauth2-proxy sidecar is a Python constant (`catalog/render.py:132`) | **Real problem.** Every such PR fails `ci/render-golden.sh` (reproduced: rc 1 "GOLDEN DRIFT"), stays red and holds a PR slot | git (1) |
|
||||
| 2 | CNPG `imageName` untracked | 3 Clusters | The `kubernetes` manager reads `image:` only. The one tracked postgres line was the grant Job (`nextcloud-db.yaml:303`, "keep in step with spec.imageName") | **Real problem.** A real run bumps the Job and leaves the databases behind | git (1) |
|
||||
| 3 | Bogus or out-of-policy majors | 5 branches: gitea 28.2.0, qbittorrent 20.04.1, radarr 6.x, nextcloud 35, postgresql 18.6 | Odd legacy tags, plus `update.range` in `catalog/` not being read by Renovate | Risk if run for real: unmergeable PRs, which hold slots | git (2) |
|
||||
| 4 | Auto-merge of the merge gate's own host | gitea 1.24.3→1.27.3, act_runner 0.2.11→0.6.1, both "minor" | Not in the blast-radius list. A 0.x minor is breaking by semver | **Risk if run for real** | git (3) |
|
||||
| 5 | Range widening auto-merged | external-dns, headlamp (minor); longhorn (blast radius); kube-prometheus-stack (major) | Renovate widens `>=a <b`. The config's comment claimed the opposite | **Risk if run for real:** silently lets Flux adopt new minors | git (4, 9) |
|
||||
| 6 | Majors hold PR slots | 10 majors in run 354 against `prConcurrentLimit: 5` | Majors never auto-merge, so they stay open | Risk: starves auto-mergeable PRs | git (5) |
|
||||
| 7 | `Cannot find replaceString … alpine:3.22` (INFO) | 1 per run | The same HelmRelease `image:` line is extracted by `flux` and `kubernetes` (also the velero plugin) | Cosmetic. The branch is still right | git (6) |
|
||||
| 8 | velero-plugin-for-aws stuck on `v1.14.3-rc.2` | 1 dep, 0 updates | Docker versioning treats `-rc.2` as a suffix, so stable `v1.14.3` and `v1.14.4` never qualify | **Real problem** (silent) | git (7) |
|
||||
| 9 | python 3.13→3.15 as auto-mergeable "minor" | 2 files | Language runtime minor | Risk if run for real | git (8) |
|
||||
| 10 | `WARN GitHub token is required` | run 353: 5 packages, 17 deps | No github.com token | Real (they were unmaintained) | **operator, done:** run 354 has no WARN and adds `pin-dependencies`, `kubevirt-cdi`, `actions-checkout-7.x`, `major-github-artifact-actions` |
|
||||
| 11 | Floating or untagged images (`invalid-value`) | 4: jackett, plex `latest`; pihole, keycloak no tag | No version to compare | Real, already documented | none in git. Pinning by hand is an operator/PM decision |
|
||||
| 12 | `runs-on: ubuntu-latest` `invalid-version` | 11 | The github-actions manager extracts runner labels | Cosmetic, debug-only | none |
|
||||
| 13 | `Docker Manifest is unknown` (debug) | 3 | HEAD on the all-zero placeholder digests | Expected. Clears when the own-image digest PRs merge | none |
|
||||
| 14 | `Docker: error fetching data from DockerHub` 403 (debug) | 5 | Hub refuses `page=11`. Renovate already has the tags | Cosmetic. Updates were still found | none |
|
||||
| 15 | `Config migration necessary` | 1 | Top-level `"docker": {"enabled": true}` | Cosmetic, pre-existing | none (as before) |
|
||||
|
||||
**Checked and fine:**
|
||||
- The 3 own-image digest updates were found in both runs. All 4 `# renovate-digest:` markers parse.
|
||||
- No marker failed to parse.
|
||||
- No package file is under `conformance/runs` or `tests`, nor is `DECISIONS-LOG.md`, `decisions/` or
|
||||
any `*.sops.yaml` (77 package files checked).
|
||||
- `kubevirt-cdi` grouping works.
|
||||
- The schedule window behaved as designed.
|
||||
- Vulnerability alerts: none in either log.
|
||||
|
||||
## What I verified
|
||||
|
||||
- I read both job logs in full (132 and 129 lines), and the router log for 10.0.0.38 during both
|
||||
runs.
|
||||
- **`renovate-config-validator` on 44.167.0**: `Config validated successfully`. The migration diff
|
||||
is only the pre-existing `docker` block.
|
||||
- **Local dry runs.** Pinned image, `--platform=local`, debug, origin/main snapshot. "Before" is
|
||||
593d0fa and "after" is this config; the GitHub-hosted deps were skipped in both.
|
||||
- **Extraction:** `regex` went from 6 files / 7 deps to **19 files / 20 deps**. Every other
|
||||
manager is unchanged: flux 15, github-actions 24, kubernetes 131, kustomize 2.
|
||||
- **Branches:** 33 before, **29 after**. Removed: gitea-28.x, qbittorrent-20.x, radarr-6.x,
|
||||
nextcloud-35.x and postgresql-18.x. Added: velero `v1.14.3-rc.2 → v1.14.4` (patch).
|
||||
- **Gitea, qbittorrent, radarr, sonarr, semaphore and seerr branches** now each carry
|
||||
`catalog/<svc>.yaml` + `apps/wave-*/<svc>.yaml`.
|
||||
- **The oauth2-proxy branch** carries `catalog/render.py` plus the 5 rendered apps and
|
||||
`platform/crafty`.
|
||||
- **The postgresql-16.x branch** carries all three Clusters.
|
||||
- The 2 flux docker duplicates report `disabled`.
|
||||
- **render==golden holds for the new branch shape.**
|
||||
- In the toolbox, I applied the gitea branch edit (catalog + apps) and the oauth2-proxy branch
|
||||
edit (`render.py` constant + 5 apps) textually. `./ci/render-golden.sh` reported
|
||||
`all 10 onboarded service golden(s) reproduce`, rc 0.
|
||||
- Negative control, the old shape with only `apps/wave-0/gitea.yaml` bumped: rc 1,
|
||||
`GOLDEN DRIFT`.
|
||||
- Both edits were reverted afterwards.
|
||||
|
||||
## What I did NOT verify
|
||||
|
||||
- **The effect of the automerge, label and dashboard-approval rules (3, 4, 5, 8). UNVERIFIED in a
|
||||
run.** `--platform=local` stops before branch processing, so I saw only which updates exist, not
|
||||
their merged flags. The matchers are standard (`matchPackageNames`, `matchManagers`,
|
||||
`matchCurrentValue`, `matchUpdateTypes`). The next dispatch's debug log shows them per branch.
|
||||
- **`allowedVersions` under docker versioning** used Renovate's "Falling back to npm semver
|
||||
syntax" path (16 debug lines). That it filters is shown by the five removed branches.
|
||||
- **render==golden for the other app branches** (qbittorrent, radarr, sonarr, semaphore, seerr). I
|
||||
proved it only for gitea and oauth2-proxy. They have the same shape: one `source.image` line ↔
|
||||
one rendered `image:` line.
|
||||
- **The `allowedVersions` rules duplicate `catalog/*/update.range`** and can drift from it. Nothing
|
||||
checks them against each other. A lint comparing the two is the obvious follow-up.
|
||||
- **Any real (non-dry) run.** None has happened. PR creation, labels, auto-merge through Gitea's
|
||||
API and the Dependency Dashboard issue are all unobserved.
|
||||
- **Sensitive path?** `renovate.json5` is not in `infra/gitea/approval-policy.json`, as far as I
|
||||
know. CI's `approval-policy` result on the PR is the measurement.
|
||||
@@ -0,0 +1,113 @@
|
||||
---
|
||||
date: 2026-10-30
|
||||
branch: feat/renovate-track-keycloak-operator
|
||||
title: Renovate tracks the Keycloak operator (the real Keycloak version), never auto-merged; the catalog's phantom image is pinned as documentation and disabled
|
||||
---
|
||||
|
||||
## What changed
|
||||
|
||||
- **`platform/keycloak/kustomization.yaml`**: each of the three `keycloak-k8s-resources/26.0.6`
|
||||
release URLs (two CRDs and `kubernetes.yml`) now has a
|
||||
`# renovate: datasource=github-tags depName=keycloak/keycloak-k8s-resources` marker on the line
|
||||
above it. That is the format the existing `custom.regex` marker manager parses (the kubevirt
|
||||
pattern). A comment explains that these URLs are the Keycloak version. The `Keycloak` CR has no
|
||||
`spec.image`, so the operator's `RELATED_IMAGE_KEYCLOAK` picks the server image.
|
||||
- **`renovate.json5`** has two new packageRules:
|
||||
- **`keycloak/keycloak-k8s-resources`**: `groupName: keycloak-operator`, `automerge: false`,
|
||||
`addLabels: [needs-review, blast-radius]`. A comment explains why. The operator, the CRDs and
|
||||
the server are released in lockstep. The IdP gates SSO for every app and for kubectl. And
|
||||
`passkey-reconciler.yaml` encodes Keycloak 26.0.6 Admin API shapes that the static gate never
|
||||
exercises. Majors still go through the existing dashboard-approval rule.
|
||||
- **`quay.io/keycloak/keycloak`**: `enabled: false`. Its only occurrences are in files that
|
||||
deploy nothing.
|
||||
|
||||
The "STILL CANNOT FIX" comment also gains a one-line correction for keycloak.
|
||||
- **`catalog/keycloak.yaml`**: `source.image` changed from `quay.io/keycloak/keycloak` (no tag) to
|
||||
`quay.io/keycloak/keycloak:26.0.6`. A comment says the image is DOCUMENTATION-ONLY and that the
|
||||
operator chooses the real one. `apps/wave-1/keycloak.yaml` was re-rendered, which changes one
|
||||
line.
|
||||
- **`platform/keycloak/README.md`**:
|
||||
- Corrects the false claim "Renovate maintains the version". Until now Renovate could not see
|
||||
the version.
|
||||
- Adds a new section, **"Upgrading Keycloak: the operator IS the version"**. It lists the 26.0.6
|
||||
assumptions in the passkey reconciler to diff against a new tag, and the post-merge checks.
|
||||
|
||||
**The phantom: pin and disable, not delete.** `apps/wave-1/keycloak.yaml` is not listed in
|
||||
`apps/wave-1/kustomization.yaml`, and render-golden excludes it (`RENDER_GOLDEN_NOT_ONBOARDED`).
|
||||
Deleting it would still not be a no-op:
|
||||
|
||||
- It is the fixture for the keycloak cases in `apps/wave-1/tests/app-slis.test.yaml` (the
|
||||
StatefulSet-based `keycloak-down` rule). Those cases are discovered by the
|
||||
every-PrometheusRule-in-apps/wave-1 convention.
|
||||
- Removing it means moving that rule and its tests to `platform/keycloak`. That is a separate
|
||||
observability change, not a Renovate one.
|
||||
|
||||
Pinning plus `enabled: false` changes one line in a file nothing applies. It cannot affect the
|
||||
cluster, and render-golden stays green.
|
||||
|
||||
## What I verified
|
||||
|
||||
- **Live state, prod, read-only kubectl, 2026-10-30.**
|
||||
- Keycloak CR `keycloak` has an empty `spec.image`.
|
||||
- The operator Deployment runs `quay.io/keycloak/keycloak-operator:26.0.6`, imageID
|
||||
`sha256:8e3a1a56346f…`, with `RELATED_IMAGE_KEYCLOAK=quay.io/keycloak/keycloak:26.0.6`.
|
||||
- `keycloak-0` and `keycloak-1` both run `quay.io/keycloak/keycloak:26.0.6`, imageID
|
||||
`sha256:a93d22e13b86…`.
|
||||
- There is no PrometheusRule containing "keycloak" in any namespace. This confirms the phantom
|
||||
deploys nothing, including its `keycloak-down` rule (see the next section).
|
||||
- **`renovate-config-validator`** on the pinned `ghcr.io/renovatebot/renovate:44.167.0`:
|
||||
`Config validated successfully`. The only migration note is the pre-existing `docker` block.
|
||||
- **Local dry run** (`RENOVATE_PLATFORM=local`, `RENOVATE_DRY_RUN=full`, debug, the same pinned
|
||||
image, this worktree, with a GitHub token passed by environment variable; the token string
|
||||
occurs 0 times in the log):
|
||||
- The regex manager went to 21 files / 24 deps.
|
||||
- `keycloak/keycloak-k8s-resources` was extracted three times from
|
||||
`platform/keycloak/kustomization.yaml`, each at `currentValue 26.0.6`, datasource
|
||||
`github-tags`, versioning `semver`.
|
||||
- Each extraction has one update, `26.8.1`, updateType `minor`, and all three share **one**
|
||||
`branchName: renovate/keycloak-operator`.
|
||||
- `quay.io/keycloak/keycloak` was extracted from `catalog/keycloak.yaml` (regex) and from
|
||||
`apps/wave-1/keycloak.yaml` (kubernetes) at 26.0.6, with `skipReason: disabled` and no
|
||||
updates.
|
||||
- **Rule effects.** `--platform=local` does not print each branch's merged flags. So I ran
|
||||
Renovate's own `applyPackageRules` (from `dist/util/package-rules` in the same 44.167.0 image)
|
||||
over this `renovate.json5` for each case:
|
||||
|
||||
| Update | Result |
|
||||
|---|---|
|
||||
| operator minor 26.0.6 → 26.8.1 | `automerge:false`, `groupName:keycloak-operator`, labels `dependencies, automated-update, needs-review, blast-radius` |
|
||||
| operator patch | same as the minor |
|
||||
| operator major | `automerge:false`, `dependencyDashboardApproval:true`, labels add `breaking` |
|
||||
| `quay.io/keycloak/keycloak`, catalog and rendered | `enabled:false` |
|
||||
| control: sonarr patch | `automerge:true`, so the rule did not disable auto-merge globally |
|
||||
- **render-golden, host:** `render.py --selftest` passed, and `all 10 onboarded service golden(s)
|
||||
reproduce`. Before the pin, the committed phantom was byte-identical to the canonical render. I
|
||||
re-rendered it after the pin.
|
||||
- **Toolbox gate** (commit 24db269, worktree with the ENGINE shim mounting `.git` and the spec
|
||||
repo, `DEV_KUBECONFIG=/dev/null`): **rc 3**.
|
||||
- The only stage that did not run is **`gitea-settings`**.
|
||||
- spec-immutability, decisions-log, lint, l0, render-golden, l1 and approval-policy all passed.
|
||||
- L2/L3 `conformance` scaffold-skipped, as expected.
|
||||
- **Not green.**
|
||||
- **Sensitive paths:** none touched (checked against `infra/gitea/approval-policy.json`), so no
|
||||
`/approve-override` is needed.
|
||||
|
||||
## What I did NOT verify
|
||||
|
||||
- **A real Renovate run.** No PR was opened by Renovate. The labels and `automerge:false` are
|
||||
proven by Renovate's own matcher, not by an opened PR.
|
||||
- **That 26.8.1 is safe to adopt.** I did not diff 26.0.6 against 26.8.1. That includes the
|
||||
reconciler's assumptions: `recurseExecutions` displayName, `updateExecutions`, the
|
||||
`RpEntityName` guard, `requiredActions` REPLACE, and config aliases. The README section lists
|
||||
them for whoever reviews the first bump PR. It also says to take or confirm a fresh CNPG backup
|
||||
first, because a server minor may migrate the schema.
|
||||
- **FINDING, not fixed: Keycloak has no deployed "IdP down" alert.** The `keycloak-down` SLI rule
|
||||
exists only inside the undeployed `apps/wave-1/keycloak.yaml`. promtool tests it, but it is not
|
||||
on the cluster: there is no keycloak PrometheusRule live. Separately, because that file exists,
|
||||
`render.py --emit-waves` would treat keycloak as onboarded. It would then add a Deployment named
|
||||
`keycloak` beside the operator's StatefulSet (the known `--emit-waves` hazard). The proper fix is
|
||||
a separate PR: move the rule and its tests into `platform/keycloak`, then delete the phantom.
|
||||
- **The catalog tag can drift.** Nothing ties `catalog/keycloak.yaml`'s documentation tag to the
|
||||
operator URLs. It must be updated by hand after an operator bump, and the README says so.
|
||||
- **Concurrent branches** `fix/renovate-hold-auth-and-self` and `feat/pin-pihole-jackett-plex`
|
||||
also edit `renovate.json5`. Neither had merged when I checked. A rebase may be needed.
|
||||
Reference in new issue
Block a user