fix(flux): vendor external-snapshotter manifests locally (stop remote-base build flake)

The kustomization pulled two REMOTE github bases (?ref=v8.2.0) that Flux's kustomize-controller
git-fetched on every reconcile; those fetches intermittently exceeded the 27s timeout ->
'kustomize build failed' BuildFailed events -> the whole platform tier stalled whenever GitHub was
slow. Vendored the exact v8.2.0 output to local crds.yaml + snapshot-controller.yaml (built with
kubectl kustomize; images transformer still re-pins the controller to v8.2.0), so the build is now
offline + deterministic. No change to what's deployed. platform/kubevirt has the same latent pattern.

Co-Authored-By: Claude Opus 4.8 <[email protected]>

platform/external-snapshotter/kustomization.yaml

@@ -29,17 +29,24 @@
 #   * The `client/config/crd` base also ships the beta VolumeGroupSnapshot CRDs; that feature is
 #     gated OFF in the controller (no --enable-volume-group-snapshots arg), so they are inert.
 #
-# Kustomize loads these as REMOTE bases (github.com/...?ref=<tag>) — the same remote-manifest
-# pattern platform/kubevirt uses for the KubeVirt/CDI operators; Flux's kustomize-controller
-# fetches them identically at reconcile.
+# VENDORED (was remote github bases). The two upstream kustomize dirs are built to LOCAL files
+# (crds.yaml, snapshot-controller.yaml) at v8.2.0 and committed here. Previously these were REMOTE
+# bases (github.com/...?ref=v8.2.0) that Flux's kustomize-controller `git fetch`ed on EVERY reconcile;
+# those fetches intermittently hit the controller's 27s timeout -> "kustomize build failed" -> the
+# WHOLE `platform` tier flaked (a transient GitHub slowness stalled every downstream app). Local files
+# make the build OFFLINE + deterministic. NOTE: platform/kubevirt still uses the same remote-base
+# pattern and carries the same latent fragility (vendor it too if it flakes).
+# RE-VENDOR on a version bump:
+#   kubectl kustomize "https://github.com/kubernetes-csi/external-snapshotter/client/config/crd?ref=vX.Y.Z" > crds.yaml
+#   kubectl kustomize "https://github.com/kubernetes-csi/external-snapshotter/deploy/kubernetes/snapshot-controller?ref=vX.Y.Z" > snapshot-controller.yaml
 apiVersion: kustomize.config.k8s.io/v1beta1
 kind: Kustomization
 resources:
-  # renovate: datasource=github-releases depName=kubernetes-csi/external-snapshotter
-  - https://github.com/kubernetes-csi/external-snapshotter/client/config/crd?ref=v8.2.0
-  # renovate: datasource=github-releases depName=kubernetes-csi/external-snapshotter
-  - https://github.com/kubernetes-csi/external-snapshotter/deploy/kubernetes/snapshot-controller?ref=v8.2.0
+  - crds.yaml
+  - snapshot-controller.yaml
 images:
-  # Re-pin the controller image to the base ref so controller == CRD version (see header note).
+  # renovate: datasource=github-releases depName=kubernetes-csi/external-snapshotter
+  # Controller image == CRD version. A version bump = re-vendor crds.yaml + snapshot-controller.yaml
+  # at the new tag (see header) AND bump this newTag.
   - name: registry.k8s.io/sig-storage/snapshot-controller
     newTag: v8.2.0