test(conformance): correct stale ImageVolume-gate rationale for k3s v1.36.4

The three KubeVirt VM conformance tests (vm-lifecycle, vm-default-deny,
vm-data-survival) carried comments asserting the ALPHA `ImageVolume` feature
gate is DISABLED "on this k3s v1.31 cluster" and that the apiserver therefore
prunes the container-disk `image` volume, breaking the containerDisk boot path.

The cluster was upgraded v1.31 -> v1.36.4. Revalidated the gate live:
  - kubernetes_feature_enabled{name="ImageVolume"} = 1 (enabled by default;
    stage="" — no longer ALPHA)
  - a server-side `kubectl apply --dry-run=server` of a Pod with an `image`
    volume RETAINS the volume + mount instead of pruning them.

So the old premise is stale: containerDisk roots would boot on 1.36.4. The
tests never asserted the gate state and never used containerDisk — they boot
from CDI DataVolume roots, which remains the correct choice because it is the
spec-required, rebuild-surviving disk model (docs/06, R-STATE-01); an ephemeral
containerDisk could never satisfy data-survival. Test logic is therefore
unchanged; only the explanatory comments are corrected (v1.31 -> v1.36.4, and
the "containerDisk is broken here" rationale marked stale with the live
evidence).

Merge gate: PASS (lint, l0, render-golden, l1 green).

Co-Authored-By: Claude Opus 4.8 <[email protected]>
This commit is contained in:
jakman85andClaude Opus 4.8 committed 2026-08-31 01:19:46 -05:00
1 parent b745bab26b
commit d60e5531b1
3 files changed
+42 -24

No files matched your search

@@ -11,12 +11,19 @@
# (R-STATE-01 covers PaaS + IaaS).
#
# METHOD (virtctl-free, filesystem-agnostic, deterministic): a VM whose ROOT is a
# CDI DataVolume on Longhorn (a mounted PVC — NOT an ephemeral containerDisk; the
# containerDisk boot path is broken on this k3s cluster because KubeVirt v1.9 serves
# the container-disk binary through a k8s `image` volume gated by the ALPHA
# `ImageVolume` feature gate, which k3s v1.31 has disabled → the apiserver prunes the
# volume and the guest dies at OCI init. DataVolume disks bypass that path and are the
# spec-required disk model anyway — docs/06/R-STATE-01). The VM also has a SECOND
# CDI DataVolume on Longhorn (a mounted PVC — NOT an ephemeral containerDisk). A
# containerDisk root is EPHEMERAL — discarded when the VM is destroyed — so it could
# never prove data-survival; the spec-required disk model here is a Longhorn-backed
# DataVolume that OUTLIVES the VM (docs/06/R-STATE-01), which is exactly what this test
# destroys-and-rebuilds. (Feature-gate note, revalidated 2026-08: an earlier revision
# of this comment also claimed the containerDisk BOOT path was broken on this cluster —
# KubeVirt v1.9 serves the container-disk binary through a k8s `image` volume gated by
# the ALPHA `ImageVolume` feature gate, which k3s v1.31 had DISABLED, so the apiserver
# pruned the volume and the guest died at OCI init. That premise is now STALE: the
# cluster is k3s v1.36.4, where ImageVolume is ENABLED by default
# (kubernetes_feature_enabled{name="ImageVolume"}=1; a server-side dry-run RETAINS an
# `image` volume rather than pruning it), so containerDisk roots would boot — DataVolume
# is used purely because only it survives rebuild.) The VM also has a SECOND
# Longhorn BLOCK data disk; cloud-init writes a unique canary to that raw block device
# and powers the guest off; runStrategy RerunOnFailure means
# a clean shutdown STAYS down (VMI -> Succeeded), so the write is known-complete and