Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
f9446be381 |
@@ -81,36 +81,7 @@ Measured on prod 2026-10-04, read-only, via the pinned toolbox:
|
|||||||
- `--emit-waves` was **not** run (it re-onboards `vm-demo` + `keycloak`); only the per-service
|
- `--emit-waves` was **not** run (it re-onboards `vm-demo` + `keycloak`); only the per-service
|
||||||
render path was used, so no wave kustomization changed.
|
render path was used, so no wave kustomization changed.
|
||||||
|
|
||||||
## This PR needs a human approval (sensitive path) — MEASURED, not predicted
|
## This PR needs a human approval (sensitive path)
|
||||||
|
|
||||||
CI run #230 on PR #49, head `f9446be3`: **`MERGE GATE: BLOCKED`, and `approval-policy` is the ONLY
|
|
||||||
failing stage.** Read from the job log, not from the status tick:
|
|
||||||
|
|
||||||
[skip] stage spec-immutability: SKIPPED (not run) <- sibling spec repo absent in CI; expected
|
|
||||||
[ ok ] stage decisions-log: pass
|
|
||||||
[ ok ] stage lint: pass
|
|
||||||
[ ok ] stage l0: pass
|
|
||||||
[ ok ] stage render-golden: pass
|
|
||||||
[ ok ] stage l1: pass
|
|
||||||
[fail] stage approval-policy: FAIL
|
|
||||||
[ ok ] stage gitea-settings: pass <- could NOT run locally; green in CI
|
|
||||||
[skip] stage conformance: SKIPPED (not run)
|
|
||||||
|
|
||||||
sensitive paths touched:
|
|
||||||
conformance/tests/l1-rendering/container-workload-render/golden/expected.yaml
|
|
||||||
conformance/tests/l1-rendering/egress-class-render/golden/egress-internet.expected.yaml
|
|
||||||
conformance/tests/l1-rendering/egress-class-render/golden/egress-vpn.expected.yaml
|
|
||||||
|
|
||||||
Exactly the three regenerated goldens, nothing else. `l1` and `render-golden` both pass in CI,
|
|
||||||
which is the independent confirmation that the regenerated goldens are right rather than merely
|
|
||||||
self-consistent with my local run.
|
|
||||||
|
|
||||||
One local-reproduction note worth recording, because it wasted a step: running
|
|
||||||
`PR_NUMBER=49 SETTINGS_API_TOKEN=... ci/approval-policy.sh` with the credential from
|
|
||||||
`git credential fill` reports `could not determine PR author — BLOCKING`. That is an **artifact**,
|
|
||||||
not a finding — `~/.git-credentials` holds a *password*, and `Authorization: token <password>`
|
|
||||||
returns 401 `user does not exist [uid: 0]`. The stage needs a real API token. I nearly reported
|
|
||||||
that 401 as the CI failure; the job log is what settled it.
|
|
||||||
|
|
||||||
Regenerating the L1 goldens means this branch touches `conformance/**`, which is in
|
Regenerating the L1 goldens means this branch touches `conformance/**`, which is in
|
||||||
`sensitive_paths` in `infra/gitea/approval-policy.json` ("the tests and the harness; changing them
|
`sensitive_paths` in `infra/gitea/approval-policy.json` ("the tests and the harness; changing them
|
||||||
|
|||||||
Reference in new issue
Block a user