Compare commits
1
Commits
| Author | SHA1 | Date | |
|---|---|---|---|
|
|
b946c475c6 |
@@ -185,12 +185,6 @@ missing from its test. `make -C ci test` goes from **FAILED to all suites passed
|
|||||||
- **`?limit=1000` is not the culprit.** Queried `/issues/38/comments` with `limit=1000`, `limit=50`
|
- **`?limit=1000` is not the culprit.** Queried `/issues/38/comments` with `limit=1000`, `limit=50`
|
||||||
and no limit using my own credentials: `type=array` in all three. So the difference is the
|
and no limit using my own credentials: `type=array` in all three. So the difference is the
|
||||||
credential, not the query.
|
credential, not the query.
|
||||||
- **The root cause is confirmed by Gitea, in its own words.** Run 206 (the fix in place):
|
|
||||||
`[warn] cannot read PR COMMENTS from Gitea — token does not have at least one of required
|
|
||||||
scope(s), required=[read:issue], token scope=read:admin,read:repository.` followed by the
|
|
||||||
instruction to post the override as a review. That is the diagnosis the first attempt should
|
|
||||||
have produced, and `gitea-settings: pass` in the same run. The stage still ends `FAIL`, correctly
|
|
||||||
— there is no valid override on the PR yet.
|
|
||||||
- **Toolbox merge gate** (`./infra/devcontainer/dev.sh run bash -c './ci/gate.sh'`), run on the
|
- **Toolbox merge gate** (`./infra/devcontainer/dev.sh run bash -c './ci/gate.sh'`), run on the
|
||||||
rebased branch: **rc 3, `MERGE GATE: UNDETERMINED`**. Green stages: spec-immutability,
|
rebased branch: **rc 3, `MERGE GATE: UNDETERMINED`**. Green stages: spec-immutability,
|
||||||
decisions-log, lint, l0 (23 offline cases, 0 failures), render-golden including the new
|
decisions-log, lint, l0 (23 offline cases, 0 failures), render-golden including the new
|
||||||
@@ -208,13 +202,12 @@ missing from its test. `make -C ci test` goes from **FAILED to all suites passed
|
|||||||
diagnoses itself. The **accepting** branch — directive found → live permission lookup → exit 0 —
|
diagnoses itself. The **accepting** branch — directive found → live permission lookup → exit 0 —
|
||||||
has never executed. Posting the override as a **review** on PR #38 is its first real test, and
|
has never executed. Posting the override as a **review** on PR #38 is its first real test, and
|
||||||
I would not be surprised by a third round.
|
I would not be surprised by a third round.
|
||||||
- **`read:issue` is the right scope name — Gitea said so itself, so this is no longer a guess.**
|
- **The `read:issue` scope name is unverified.** `set-ci-token.sh` now requests it, but I did not
|
||||||
Run 206 printed Gitea's own message: `token does not have at least one of required scope(s),
|
mint a token to confirm Gitea 1.24.3 accepts that exact string — the script's own header warns
|
||||||
required=[read:issue], token scope=read:admin,read:repository`. That both confirms the root
|
that "Gitea token scopes are coarse; grant the least that works on your version and confirm the
|
||||||
cause and names the string, which matters because this repo has been burned by a token *name*
|
check goes green rather than assuming the scope name", and this repo has already been burned by
|
||||||
that could not exist (`GITEA_SETTINGS_TOKEN`). What is **still** unverified is that the token
|
a *name* that could not exist (`GITEA_SETTINGS_TOKEN`). **If the mint fails, the scope string is
|
||||||
*mint* accepts it — `POST /users/{u}/tokens` with that scope has not been run. The review route
|
the first suspect.** The review route does not depend on it.
|
||||||
does not depend on it.
|
|
||||||
- **I did not verify that Gitea lets a PR's own author submit a `COMMENT`-type review.** Gitea
|
- **I did not verify that Gitea lets a PR's own author submit a `COMMENT`-type review.** Gitea
|
||||||
blocks author self-*approval*; "Comment" is expected to be allowed, and that expectation is now
|
blocks author self-*approval*; "Comment" is expected to be allowed, and that expectation is now
|
||||||
load-bearing for the recommended route. It is one click to find out, and I deliberately did not
|
load-bearing for the recommended route. It is one click to find out, and I deliberately did not
|
||||||
|
|||||||
Reference in new issue
Block a user