0 Fork 0

Files

T

jakman85andClaude Opus 5 834928c237 fix(gitops): CDI cold-start deadlock repaired IN THE GRAPH, not by a pre-apply

`platform-config` applied the CDI CR *and* cdi-storageprofiles.yaml in ONE pass.
StorageProfile's CRD does not exist until cdi-operator reconciles that CR, and
Flux server-side dry-runs every object before applying any — so the unknown kind
aborted the tier, the CR was never applied, the CRD was never created, and the
tier could NEVER converge. Observed on prod: cdi-operator Available 12h, no CDI
CR, no storageprofiles CRD, every downstream tier blocked.

The profiles now live in their own tier ./platform-config-cdi with
dependsOn: platform-config and wait: true. Because dependsOn is REVISION-gated
and platform-config runs wait: true, the CDI CR must be applied AND healthy —
exactly the event that creates the CRD — before the profiles are applied. Cold
clusters order themselves. `standup.sh crds` is retained as a fallback for
clusters already stuck, and because it is idempotent.

THE GENERALISABLE RULE (recorded in clusters/README.md): a CR whose CRD is
created by a CONTROLLER AT RUNTIME is second-order and needs its own pass.
cdi-operator.yaml registers exactly ONE CRD (cdis.cdi.kubevirt.io); storageprofiles,
datavolumes, datasources and dataimportcrons appear only after it reconciles the
CDI CR. An audit found StorageProfile is the only second-order kind in
platform-config — KubeVirt, CDI, KeycloakRealmImport, CNPG Cluster,
VolumeSnapshotClass, ClusterIssuer, PrometheusRule, ServiceMonitor and the Cilium
L2 CRs all have their CRD in git or in a chart.

Moving the CDI CR up into `platform` was rejected: that would put CDI's health on
the tier the CNI gates and everything waits on — the mistake the oauth2-proxy and
headlamp splits exist to undo.

apps-vms gains dependsOn: platform-config-cdi. LOAD-BEARING, not cosmetic:
apps/vms/unifi/20-datavolume.yaml provisions on storageClassName: longhorn-vm and
its comment claimed platform-config guaranteed the profiles — which this move
would have silently falsified.

THE PRUNE TRANSIENT, MEASURED RATHER THAN ASSUMED. platform-config has
prune: true, so it deletes both profiles once, CDI recreates them with empty spec,
and the new tier re-applies the overrides ~30-60s later. Compared our override
against CDI's unaided inference for the same Longhorn provisioner on dev:
  longhorn-vm (we override)     spec RWX/Block  -> status ReadWriteMany/Block
  longhorn-static (no override) spec unset      -> status ReadWriteOnce/Block
Both infer cloneStrategy: snapshot. So cloneStrategy is NOT at risk; accessModes
IS — unaided CDI gives RWO. A DataVolume provisioned on longhorn-vm inside the
window would be stamped RWO/Block and be PERMANENTLY non-live-migratable. Flux can
no longer cause it (apps-vms gates on the new tier); a human must not do it by hand.
Corroborating evidence that the recreate happens at all: dev has 5 StorageClasses
and 5 StorageProfiles, three with fluxOwner=NONE, spec unset and status populated
— CDI creating and inferring them with no Flux involvement.

MERGE PRECONDITION: `flux get kustomization platform-config` must be Ready on the
target first. If it is not, the profiles are pruned and sit at CDI defaults until
it recovers — and prod was in that state hours earlier. Fallback is the two-step
the Cilium move used (merge with prune: false, verify the ownership label moved,
restore prune: true).

substituteFrom: cluster-vars is declared even though the manifest has no ${TOKEN},
deliberately: conformance/tests/l0-static/flux-postbuild-substitution only audits
paths whose Kustomization declares it, so omitting it would move the file OUT of
the audited set — a blind spot for a future literal-token ship. Gate confirms it
stayed in (path=./platform-config-cdi files=2 defined=0 hazards=0). No SOPS
decryption stanza: the moved file is two plain CRs, so no overlay change was needed.

VERIFIED INDEPENDENTLY OF THE AGENT: platform-config renders 0 StorageProfile
while keeping the CDI and KubeVirt CRs; platform-config-cdi renders exactly the
two profiles; the graph is byte-identical across dev and prod with apps-vms
carrying both edges and no cycle. Full CI gate PASS.

KNOWN FOLLOW-UP: bootstrap/standup.sh TIER_ORDER does not yet include
platform-config-cdi, so `resume` will not wait on it. Another agent holds that
file; the PM will add it.

Refs R-GITOPS-01, R-ENV-02.

Co-Authored-By: Claude Opus 5 <[email protected]>

2026-09-06 08:36:42 -05:00

crds.yaml

fix(flux): vendor external-snapshotter manifests locally (stop remote-base build flake)

2026-08-31 10:54:43 -05:00

kustomization.yaml

fix(gitops): CDI cold-start deadlock repaired IN THE GRAPH, not by a pre-apply

2026-09-06 08:36:42 -05:00

README.md

fix(gitops): CDI cold-start deadlock repaired IN THE GRAPH, not by a pre-apply

2026-09-06 08:36:42 -05:00

snapshot-controller.yaml

fix(flux): vendor external-snapshotter manifests locally (stop remote-base build flake)

2026-08-31 10:54:43 -05:00

README.md

external-snapshotter (CSI snapshot control plane)

Installs the cluster-singleton kubernetes-csi/external-snapshotter:

the snapshot.storage.k8s.io CRDs — VolumeSnapshot, VolumeSnapshotContent, VolumeSnapshotClass (v1, GA);
the snapshot-controller Deployment (into kube-system, the upstream default) that reconciles those objects against any CSI driver's CreateSnapshot/DeleteSnapshot.

Neither k3s nor the Longhorn chart ships this. It is a prerequisite for:

VolumeSnapshotClass (driver.longhorn.io) — see ../longhorn/volumesnapshotclass.yaml (applied by platform-config).
CDI snapshot smart-clone — the CDI StorageProfiles set cloneStrategy: snapshot (see ../kubevirt/cdi-storageprofiles.yaml); CDI clones VM disks by taking a CSI VolumeSnapshot instead of a slow host-assisted byte copy.
Clearing the CDIDefaultStorageClassDegraded alert — a default virtualization StorageClass must support both smart-clone and ReadWriteMany.

Wiring

Pass: platform (controllers). Registers the CRDs.
The VolumeSnapshotClass CR that consumes the CRDs lives in the platform-config pass (dependsOn: platform), per the controllers/configs split.
The CDI StorageProfiles live one pass further out, in platform-config-cdi (dependsOn: platform-config) — storageprofiles.cdi.kubevirt.io is created by cdi-operator only after it reconciles the CDI CR, so they cannot share a pass with it. See clusters/base/platform-config-cdi.yaml.

Version

Pinned to v8.2.0 (Renovate-maintained). The v8.x line aligned to Kubernetes 1.31 at v8.1.0; this cluster is now k3s v1.36.4, so the pin should be re-checked for 1.36 (a newer external-snapshotter line may be the version-matched choice) — do not treat v8.2.0 as verified against 1.36 yet. The snapshot-controller image is re-pinned to the same tag via the kustomization images transformer (the upstream setup manifest lags on the image tag).