jakman85andClaude Opus 5
5fa278f61c
R-TEST-03 runs the conformance subset a change TOUCHES. That has one blind spot, and it
is the worst-shaped kind: an invariant that quantifies over the whole tracked tree — or
over subtrees ci/touched-requirements.sh's coarse path map keys to NOTHING (apps/, infra/,
most of platform/) — cannot be selected BY the requirements a change touches, because the
change most likely to break it attributes no requirement at all. Requirement-scoped
selection then filters the check out of exactly that change.
The repo's answer had been a hand-written "UNCONDITIONAL" stage per such check in
ci/l0.sh: 3c flux-postbuild-substitution, 3d keycloak-client-secret-reconciler, 3e
bulk-tier-distinct-from-replicated. Three near-identical 12-line rationales, three
hardcoded check.sh paths, three copies of the same rc 0/3/* case block — and worst, a
mechanism that failed SILENTLY, because whoever added the NEXT whole-repo invariant had
to REMEMBER to write a stage, and if they forgot the check ran only when some unrelated
requirement happened to be touched.
A test now DECLARES the scope of its invariant and the runner enforces it:
metadata:
annotations:
conformance.home.k3s/scope: "whole-repo"
* conformance/lib/common.sh conf_dirs_for_scope(s) resolves the annotation. Carries the
general rationale, once, instead of per stage.
* conformance/run.sh --include-scope SCOPE unions declaring tests into select_dirs,
still bounded by --layer. New --print-selection resolves the
selection and exits, running nothing.
* lib/run_l1_offline.py --unwired-scope: a SKIP of a declaring test exits 3, not 0.
--summary-out: one step-summary line per executed check.
* ci/l0.sh Stage 3b gains --include-scope whole-repo and an rc-3 arm.
Stages 3c/3d/3e DELETED (-150 lines).
* ci/l1.sh, ci/conformance.sh pass --include-scope too, so the next whole-repo invariant
at ANY layer needs only the annotation.
rc 3 SEMANTICS PRESERVED EXACTLY. A whole-repo check reporting "nothing to audit" is
reporting that the tree it audits has VANISHED. The deleted stages called that "not a
pass" and set the gate's rc=3; the runner now returns 3 and ci/l0.sh maps it to rc=3.
A missing check file still degrades to not-green, never to silence.
THE REASONING WAS RELOCATED, NOT DELETED. Each stage's incident narrative moved into the
header of the test it describes, beside its scope annotation: the Cilium k8sServiceHost
empty-substitution CNI outage (2026-09-01), 12 unusable Keycloak clients behind a green
cluster (2026-09-06), and a multi-TB bulk volume landing on the 3-replica tier.
AUDITED ALL 13 EXISTING l0-static TESTS, individually. 10 declare whole-repo scope; 3 are
DELIBERATELY left requirement-scoped and say so in their own headers:
* placeholder-guard-coupling — inputs are bootstrap/ + clusters/, both already mapped to
a requirement it declares. Scoping cannot hide a breaking change.
* dev-nodes-provisioned-as-code — inputs are infra/ and nothing else.
* spec-immutability-enforced — inputs are ci/ and the read-only spec repo.
The latter two were nonetheless under-gated because the PATH MAP was incomplete, which is
the right place to fix a path-scoped invariant: infra/* -> R-ENV-01 added, and R-TEST-06
added to .gitea/*|ci/* (it is no longer an uncovered ID — spec-immutability-enforced
carries the label, so attributing it no longer false-blocks the coverage gate).
NEW conformance/tests/l0-static/whole-repo-invariants-wired (R-TEST-03) keeps the
declarative mechanism honest for ALL declaring tests at once, replacing the three tests'
individual "ci/l0.sh greps my own check.sh path" self-assertions. It proves the union
EMPIRICALLY: with a requirement filter matching no test the L0 selection is empty, and
with --include-scope it is every declaring test; a scope-declared synthetic SKIP exits 3
while an undeclared one exits 0; and a ci/*.sh that hardcodes a check.sh path must belong
to a test that also declares the scope, so the bespoke pattern cannot creep back.
TASK 2 — a changed test attributes the requirements it CERTIFIES.
ci/touched-requirements.sh gains detection rule 3: a change anywhere under
conformance/tests/<test>/ attributes that test's own conformance.home.k3s/R-* labels, read
from its chainsaw-test.yaml. The content scan could not close this — it reads only
added/removed lines, so it sees a change to the LABEL BLOCK but not to the test BODY,
which is exactly the case that matters. Labels are read from HEAD or, failing that, from
the BASE, so DELETING a test still attributes what it used to certify; otherwise removing
the only verifier of a requirement is the cheapest way to make the gate stop checking it.
Whole-line `#` comments are dropped first and *.md is untouched, honouring the existing
"reference, not declaration" rules.
Both changes are fail-closed: every one of them can only ADD tests or requirements to a
run, never remove one.
TESTS: new ci/tests/touched-requirements-test-attribution.test.sh (15 assertions) covers
rule 3 — body-only edit, nested-fixture walk-up, test deletion, header-comment R-IDs not
attributed, non-test paths unaffected, and both new path-map entries. The two existing
suites still pass (39 assertions). `make -C ci test` runs all three.
Co-Authored-By: Claude Opus 5 <[email protected]>
76 lines
4.4 KiB
YAML
76 lines
4.4 KiB
YAML
# =============================================================================
|
|
# L0 STATIC — Flux postBuild substitution is complete and fail-closed-safe
|
|
# Catalog: docs/14 L0 row ("Pre-apply, in CI") — runs WITHOUT a cluster.
|
|
#
|
|
# R-ENV-02 ("authored once, promoted dev -> prod") is implemented by ONE mechanism:
|
|
# `postBuild.substituteFrom cluster-vars` injecting `${TOKEN}`s into the manifests each
|
|
# Flux Kustomization renders. That mechanism FAILS OPEN — an undefined variable becomes
|
|
# the empty string while the Kustomization still reports Ready — which emptied Cilium's
|
|
# k8sServiceHost and broke the CNI on 2/3 dev nodes (DECISIONS-LOG 2026-09-01).
|
|
#
|
|
# GIVEN every Flux Kustomization under clusters/ that declares postBuild.substituteFrom,
|
|
# WHEN each `spec.path` is resolved to the exact file set it renders (following
|
|
# kustomization.yaml `resources:` transitively, not globbing the repo),
|
|
# THEN every `${...}` in those files is either DEFINED in clusters/base/cluster-vars.yaml
|
|
# or deliberately ESCAPED `$${...}`; no unescaped expansion carries a default
|
|
# operator on an undefined name (the silent-empty class strict mode does NOT catch);
|
|
# no unescaped expansion is unparseable by envsubst (which fails the WHOLE
|
|
# Kustomization); every path rendering a knob actually substitutes cluster-vars;
|
|
# every overlay-patched knob has a base default; and the check is wired into the
|
|
# merge gate as a blocking, unconditionally-run stage.
|
|
#
|
|
# This is the prerequisite proof for enabling kustomize-controller's
|
|
# StrictPostBuildSubstitutions feature gate, and the permanent guard that keeps it safe.
|
|
#
|
|
# STATUS: EXECUTABLE. `check.sh` is a pure offline assertion script (standard library
|
|
# only); conformance/run.sh --layer l0 and ci/l0.sh run it directly, and this Chainsaw
|
|
# Test wraps the SAME script.
|
|
#
|
|
# NOT proven (named in check.sh's header): this is a STATIC scan of the SOURCE manifests
|
|
# a path includes — a deliberate superset of the post-`kustomize build` stream. It does
|
|
# not render, does not prove the feature gate is enabled on the live kustomize-controller,
|
|
# and does not validate knob VALUES. R-GITOPS-01 is tagged for the narrow static slice
|
|
# only: what git says a Kustomization renders is fully determined, with no variable
|
|
# silently emptied on the way in. The live-state half is L2, untested today.
|
|
# =============================================================================
|
|
apiVersion: chainsaw.kyverno.io/v1alpha1
|
|
kind: Test
|
|
metadata:
|
|
name: flux-postbuild-substitution
|
|
labels:
|
|
conformance.home.k3s/R-ENV-02: "true"
|
|
conformance.home.k3s/R-GITOPS-01: "true"
|
|
annotations:
|
|
conformance.home.k3s/requirements: "R-ENV-02, R-GITOPS-01"
|
|
conformance.home.k3s/layer: "L0"
|
|
# WHOLE-REPO SCOPE — relocated verbatim from ci/l0.sh's hand-written "Stage 3c
|
|
# (UNCONDITIONAL)", which this annotation replaces:
|
|
#
|
|
# R-ENV-02's promote-once mechanism is `postBuild.substituteFrom cluster-vars`, and it
|
|
# FAILS OPEN: an undefined ${TOKEN} becomes the empty string and the Kustomization still
|
|
# reports Ready. That emptied Cilium's k8sServiceHost and broke the CNI on 2/3 dev nodes
|
|
# (DECISIONS-LOG 2026-09-01, "substitution race that fails OPEN").
|
|
#
|
|
# WHY IT MUST NOT BE REQUIREMENT-SCOPED: ci/touched-requirements.sh's coarse path map
|
|
# keys only clusters/* to R-ENV-02 — an edit to a SUBSTITUTED manifest under apps/ or
|
|
# platform/ attributes no requirement, so the requirement-scoped selection would filter
|
|
# this check out of exactly the change that introduces the bug. The invariant spans every
|
|
# path any Flux Kustomization substitutes (apps/, platform/, platform-config/), so it runs
|
|
# on EVERY gate invocation.
|
|
conformance.home.k3s/scope: "whole-repo"
|
|
conformance.home.k3s/safety-critical: "false"
|
|
conformance.home.k3s/executable: "true"
|
|
conformance.home.k3s/intent: >-
|
|
Every variable a substituted Flux path renders is defined in cluster-vars or
|
|
escaped, so post-build substitution cannot silently empty a value and enabling
|
|
StrictPostBuildSubstitutions cannot fail a legitimate manifest.
|
|
spec:
|
|
steps:
|
|
- name: audit-every-substituted-flux-path
|
|
description: >-
|
|
Resolve each postBuild.substituteFrom Kustomization to the files it renders and
|
|
assert every ${...} is defined or escaped, then assert the gate wires it blocking.
|
|
try:
|
|
- script:
|
|
content: bash ./check.sh
|