jakman85andClaude Opus 5
5fa278f61c
R-TEST-03 runs the conformance subset a change TOUCHES. That has one blind spot, and it
is the worst-shaped kind: an invariant that quantifies over the whole tracked tree — or
over subtrees ci/touched-requirements.sh's coarse path map keys to NOTHING (apps/, infra/,
most of platform/) — cannot be selected BY the requirements a change touches, because the
change most likely to break it attributes no requirement at all. Requirement-scoped
selection then filters the check out of exactly that change.
The repo's answer had been a hand-written "UNCONDITIONAL" stage per such check in
ci/l0.sh: 3c flux-postbuild-substitution, 3d keycloak-client-secret-reconciler, 3e
bulk-tier-distinct-from-replicated. Three near-identical 12-line rationales, three
hardcoded check.sh paths, three copies of the same rc 0/3/* case block — and worst, a
mechanism that failed SILENTLY, because whoever added the NEXT whole-repo invariant had
to REMEMBER to write a stage, and if they forgot the check ran only when some unrelated
requirement happened to be touched.
A test now DECLARES the scope of its invariant and the runner enforces it:
metadata:
annotations:
conformance.home.k3s/scope: "whole-repo"
* conformance/lib/common.sh conf_dirs_for_scope(s) resolves the annotation. Carries the
general rationale, once, instead of per stage.
* conformance/run.sh --include-scope SCOPE unions declaring tests into select_dirs,
still bounded by --layer. New --print-selection resolves the
selection and exits, running nothing.
* lib/run_l1_offline.py --unwired-scope: a SKIP of a declaring test exits 3, not 0.
--summary-out: one step-summary line per executed check.
* ci/l0.sh Stage 3b gains --include-scope whole-repo and an rc-3 arm.
Stages 3c/3d/3e DELETED (-150 lines).
* ci/l1.sh, ci/conformance.sh pass --include-scope too, so the next whole-repo invariant
at ANY layer needs only the annotation.
rc 3 SEMANTICS PRESERVED EXACTLY. A whole-repo check reporting "nothing to audit" is
reporting that the tree it audits has VANISHED. The deleted stages called that "not a
pass" and set the gate's rc=3; the runner now returns 3 and ci/l0.sh maps it to rc=3.
A missing check file still degrades to not-green, never to silence.
THE REASONING WAS RELOCATED, NOT DELETED. Each stage's incident narrative moved into the
header of the test it describes, beside its scope annotation: the Cilium k8sServiceHost
empty-substitution CNI outage (2026-09-01), 12 unusable Keycloak clients behind a green
cluster (2026-09-06), and a multi-TB bulk volume landing on the 3-replica tier.
AUDITED ALL 13 EXISTING l0-static TESTS, individually. 10 declare whole-repo scope; 3 are
DELIBERATELY left requirement-scoped and say so in their own headers:
* placeholder-guard-coupling — inputs are bootstrap/ + clusters/, both already mapped to
a requirement it declares. Scoping cannot hide a breaking change.
* dev-nodes-provisioned-as-code — inputs are infra/ and nothing else.
* spec-immutability-enforced — inputs are ci/ and the read-only spec repo.
The latter two were nonetheless under-gated because the PATH MAP was incomplete, which is
the right place to fix a path-scoped invariant: infra/* -> R-ENV-01 added, and R-TEST-06
added to .gitea/*|ci/* (it is no longer an uncovered ID — spec-immutability-enforced
carries the label, so attributing it no longer false-blocks the coverage gate).
NEW conformance/tests/l0-static/whole-repo-invariants-wired (R-TEST-03) keeps the
declarative mechanism honest for ALL declaring tests at once, replacing the three tests'
individual "ci/l0.sh greps my own check.sh path" self-assertions. It proves the union
EMPIRICALLY: with a requirement filter matching no test the L0 selection is empty, and
with --include-scope it is every declaring test; a scope-declared synthetic SKIP exits 3
while an undeclared one exits 0; and a ci/*.sh that hardcodes a check.sh path must belong
to a test that also declares the scope, so the bespoke pattern cannot creep back.
TASK 2 — a changed test attributes the requirements it CERTIFIES.
ci/touched-requirements.sh gains detection rule 3: a change anywhere under
conformance/tests/<test>/ attributes that test's own conformance.home.k3s/R-* labels, read
from its chainsaw-test.yaml. The content scan could not close this — it reads only
added/removed lines, so it sees a change to the LABEL BLOCK but not to the test BODY,
which is exactly the case that matters. Labels are read from HEAD or, failing that, from
the BASE, so DELETING a test still attributes what it used to certify; otherwise removing
the only verifier of a requirement is the cheapest way to make the gate stop checking it.
Whole-line `#` comments are dropped first and *.md is untouched, honouring the existing
"reference, not declaration" rules.
Both changes are fail-closed: every one of them can only ADD tests or requirements to a
run, never remove one.
TESTS: new ci/tests/touched-requirements-test-attribution.test.sh (15 assertions) covers
rule 3 — body-only edit, nested-fixture walk-up, test deletion, header-comment R-IDs not
attributed, non-test paths unaffected, and both new path-map entries. The two existing
suites still pass (39 assertions). `make -C ci test` runs all three.
Co-Authored-By: Claude Opus 5 <[email protected]>
77 lines
4.7 KiB
YAML
77 lines
4.7 KiB
YAML
# =============================================================================
|
|
# L0 STATIC — a placeholder value in cluster-vars is REFUSED by the guard that owns it
|
|
# Catalog: docs/14 L0 row ("Pre-apply, in CI") — runs WITHOUT a cluster.
|
|
#
|
|
# THE BUG CLASS THIS CLOSES (it has now bitten three times in one file). A guard in
|
|
# `bootstrap/standup.sh` keys on the SHAPE of a value that lives in
|
|
# `clusters/base/cluster-vars.yaml`, and nothing tied the two together. On 2026-09-05 the
|
|
# S3 placeholder changed from `TBD-PROD-S3-BACKUP-ENDPOINT` to
|
|
# `https://TBD-R2-ACCOUNT-ID.r2.cloudflarestorage.com`; the three guards matched the glob
|
|
# `TBD-*`, a PREFIX match, and `fnmatch('https://TBD-R2-…','TBD-*')` is False. All three
|
|
# guards silently stopped matching, and `standup.sh resume` would have resumed `velero` on
|
|
# prod against a nonexistent hostname: installs clean, reports healthy, NO BACKUPS EXIST.
|
|
# It was found by accident. The guard is fixed (`s3_is_placeholder`, substring); the
|
|
# COUPLING was untested, which is what makes the class reintroducible.
|
|
#
|
|
# GIVEN the repository as authored,
|
|
# WHEN the REAL predicate is extracted from bootstrap/standup.sh and executed by bash
|
|
# (never reimplemented — see check.sh "HOW THE REAL GUARD IS EXERCISED"),
|
|
# THEN (1) every authored value of a guarded knob that is placeholder-shaped by an
|
|
# INDEPENDENT detector is actually refused by that guard, in base and in every
|
|
# environment overlay;
|
|
# (2) no environment overlay carries a placeholder-shaped value for a knob no guard
|
|
# refuses;
|
|
# (3) every function in standup.sh that reads a guarded knob applies the guard to it
|
|
# (the "three guards died at once" regression);
|
|
# (4) the guard matches its own vocabulary ANYWHERE in a value, not just as a prefix
|
|
# — the exact anchoring defect above — and still accepts a real endpoint;
|
|
# AND (5) the extraction is faithful, and the check fails LOUDLY rather than silently
|
|
# testing a copy if the guard stops being a self-contained predicate.
|
|
#
|
|
# STATUS: EXECUTABLE. `check.sh` is a pure offline assertion script (standard library +
|
|
# PyYAML + bash); conformance/run.sh --layer l0 runs it directly and this Chainsaw Test
|
|
# wraps the SAME script.
|
|
#
|
|
# NOT proven: that the endpoint is REACHABLE or that backups exist (runtime facts —
|
|
# `standup.sh s3check` probes the former from a pod, l3-fault-injection/dr-restore proves
|
|
# the latter); that guards for knobs OTHER than the placeholder-refusing ones are correct;
|
|
# and that the guard runs at all in a real standup (the dispatch path is shell, executed
|
|
# only against a live cluster). R-STATE-03 is tagged for the narrow static slice only: the
|
|
# authored backup target cannot be a placeholder that the guard fails to recognise.
|
|
# =============================================================================
|
|
apiVersion: chainsaw.kyverno.io/v1alpha1
|
|
kind: Test
|
|
metadata:
|
|
name: placeholder-guard-coupling
|
|
labels:
|
|
conformance.home.k3s/R-ENV-02: "true"
|
|
conformance.home.k3s/R-STATE-03: "true"
|
|
annotations:
|
|
conformance.home.k3s/requirements: "R-ENV-02, R-STATE-03"
|
|
conformance.home.k3s/layer: "L0"
|
|
# NO `scope` ANNOTATION, DELIBERATELY — this invariant IS requirement-scoped, and was
|
|
# audited as such (2026-09-12). Its entire input surface is bootstrap/standup.sh (the
|
|
# placeholder guards) plus clusters/base/cluster-vars.yaml and clusters/<env>/
|
|
# (the values they guard). ci/touched-requirements.sh keys bootstrap/* to
|
|
# R-STATE-03 + R-GITOPS-01 and clusters/* to R-ENV-02 + R-GITOPS-01 — so EVERY path that
|
|
# can break this check already attributes one of the two requirements it declares above.
|
|
# Requirement-scoped selection therefore cannot hide a breaking change here, and declaring
|
|
# whole-repo scope would only add runtime, not coverage.
|
|
conformance.home.k3s/safety-critical: "false"
|
|
conformance.home.k3s/executable: "true"
|
|
conformance.home.k3s/intent: >-
|
|
Every placeholder-shaped value authored in cluster-vars, for any environment
|
|
overlay, is actually recognised as a placeholder by the real bootstrap guard that
|
|
is supposed to refuse it — so a value change in one file cannot silently disarm a
|
|
guard in another and enable velero against an endpoint that does not exist.
|
|
spec:
|
|
steps:
|
|
- name: couple-authored-placeholders-to-the-real-guard
|
|
description: >-
|
|
Extract the real placeholder predicate from bootstrap/standup.sh, run it against
|
|
every authored cluster-vars value the repo actually carries, and assert the guard
|
|
refuses each one an independent detector calls a placeholder.
|
|
try:
|
|
- script:
|
|
content: bash ./check.sh
|