The committed apps/ goldens were a MIX of two render flag sets: 8 services were rendered with `--no-image-automation` (no image CRs) while gitea and nextcloud carried stale ImageRepository/ImagePolicy CRs from a render WITHOUT the flag. Neither single command reproduced all goldens, and the gate did not catch it. Part A — canonical render: python3 catalog/render.py --all catalog -o apps --wave-layout --no-image-automation `--no-image-automation` is canonical: image automation is authored-but-DISABLED (DECISIONS-LOG; image-reflector/-automation controllers not installed), and every app was onboarded via this flag. Re-render drops the ImageRepository + ImagePolicy objects from gitea + nextcloud only (52 line deletions, purely the trailing image-automation blocks). No functional content changed — the nextcloud postStart hardening and gitea OIDC hook are untouched. Part B — enforcement: ci/render-golden.sh renders every onboarded catalog service with the canonical command into a temp dir and FAILS on ANY diff vs committed apps/ (missing golden or content drift), across all 10 services (not just the 3 L1 spot-checks). Not-onboarded catalog entries (keycloak, vm-demo) are excluded per DESIGN-waves. Wired as a required no-cluster stage in ci/gate.sh, ci/Makefile, and both the live (.gitea/workflows/gate.yml) and dormant (merge-gate.yaml) pipelines. Proof: tampering a golden makes the stage exit 1 (blocks merge); reverting restores exit 0. `make -C ci gate` green in the devcontainer. Co-Authored-By: Claude Opus 4.8 <[email protected]>
91 lines
4.6 KiB
YAML
91 lines
4.6 KiB
YAML
# .gitea/workflows/gate.yml — the ENFORCED PR merge gate (Phase 6, WS-GITOSS).
|
|
#
|
|
# This is the LIVE gate wired to the in-cluster Gitea Actions runner (ns gitea-actions,
|
|
# Docker executor + DinD). It runs the STATIC layers of the conformance gate — the ones
|
|
# docs/14 says run "without a cluster": spec-immutability (best-effort), lint, Kyverno L0,
|
|
# the render==golden reproducibility check, and L1 offline render checks. It is the single
|
|
# required status check on `main`
|
|
# (see branch protection). `make -C ci lint l0 render-golden l1` here is byte-identical to a laptop run
|
|
# (R-TEST-02) — the runner just installs the pinned tools from ci/versions.env first.
|
|
#
|
|
# The L2/L3 CONFORMANCE layer (behavioural + fault-injection, needs a live cluster) is
|
|
# NOT wired yet — it is a deliberate design decision (a CI toolchain image + a scoped
|
|
# in-cluster kubeconfig/RBAC for the runner). It is present below as an `if: false`
|
|
# placeholder so the shape is visible and the wiring is a one-line flip once decided.
|
|
# The full pipeline blueprint (spec-checkout, per-layer jobs, decision job) is retained
|
|
# dormant in merge-gate.yaml.
|
|
---
|
|
name: gate
|
|
|
|
on:
|
|
pull_request:
|
|
branches: [main]
|
|
push:
|
|
branches:
|
|
- main
|
|
- 'feature/**'
|
|
- 'fix/**'
|
|
- 'docs/**'
|
|
- 'chore/**'
|
|
|
|
concurrency:
|
|
group: gate-${{ github.ref }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
# Single required status check: the static merge gate.
|
|
gate:
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
with:
|
|
fetch-depth: 0 # full history so ci/touched-requirements.sh can diff vs main
|
|
|
|
- name: Install pinned CI toolchain (ci/versions.env)
|
|
run: |
|
|
./.gitea/workflows/scripts/install-tools.sh l0
|
|
./.gitea/workflows/scripts/install-tools.sh l1
|
|
|
|
# R-TEST-06: the spec is read-only to agents. The spec repo is NOT checked out into
|
|
# CI here (it is a separate repo; SPEC_REPO_SLUG is not wired into this runner), so
|
|
# the guard honestly SKIPS (exit 3) rather than faking green. A real drift/edit of a
|
|
# co-located spec would exit 1 and fail. Tolerated: exit 3 only.
|
|
# Call the script DIRECTLY, not via `make`: GNU make masks a recipe's exit code as
|
|
# its own 2 on failure, so `make spec-immutability || [ $? -eq 3 ]` would see 2 and
|
|
# fail. The script itself exits 3 on an honest skip (spec repo not checked out here),
|
|
# which we tolerate; a real drift/edit exits 1 and fails the gate.
|
|
- name: Spec immutability (R-TEST-06, skips if spec repo absent)
|
|
run: ./ci/spec-immutability.sh || [ "$?" -eq 3 ]
|
|
|
|
- name: Static gate — lint + Kyverno L0 + render==golden + L1 render
|
|
run: make -C ci lint l0 render-golden l1
|
|
|
|
# NOTE: no actions/upload-artifact step. Gitea Actions rejects upload-artifact@v4
|
|
# ("not supported on GHES" — Gitea does not implement the artifact-v2 backend), which
|
|
# would fail the job even on a green gate. JUnit + coverage are written under
|
|
# conformance/_artifacts/ in the job workspace; wire artifact upload later via the
|
|
# Gitea-compatible @v3 action or Gitea's own artifact backend if retention is wanted.
|
|
|
|
# ───────────────────────────────────────────────────────────────────────────
|
|
# PLACEHOLDER — NOT WIRED (STOP-and-report item, WS-GITOSS Phase 6).
|
|
# L2/L3 conformance (Chainsaw behavioural + fault-injection) needs a LIVE cluster.
|
|
# Turning this on is a design decision with two open sub-decisions:
|
|
# 1. Toolchain: build+push a pinned CI image to the Gitea container registry and
|
|
# reference it as the job image, vs. install-in-job from ci/versions.env (slower).
|
|
# 2. Cluster creds: how the runner reaches the cluster — the intended model is an
|
|
# in-cluster Chainsaw Job driven by its OWN scoped ServiceAccount (CI holds only a
|
|
# narrow trigger credential; the runner mounts NO SA token today). That SA + RBAC
|
|
# + the trigger secret do not exist yet.
|
|
# Kept `if: false` so it never runs (shows skipped, never fakes green — HARD RULE 4).
|
|
# ───────────────────────────────────────────────────────────────────────────
|
|
conformance:
|
|
runs-on: ubuntu-latest
|
|
needs: [gate]
|
|
if: false
|
|
steps:
|
|
- name: Placeholder
|
|
run: |
|
|
echo "L2/L3 conformance not wired — see gate.yml header + WS-GITOSS report." >&2
|
|
exit 1
|