jakman85andClaude Opus 5
5fa278f61c
R-TEST-03 runs the conformance subset a change TOUCHES. That has one blind spot, and it
is the worst-shaped kind: an invariant that quantifies over the whole tracked tree — or
over subtrees ci/touched-requirements.sh's coarse path map keys to NOTHING (apps/, infra/,
most of platform/) — cannot be selected BY the requirements a change touches, because the
change most likely to break it attributes no requirement at all. Requirement-scoped
selection then filters the check out of exactly that change.
The repo's answer had been a hand-written "UNCONDITIONAL" stage per such check in
ci/l0.sh: 3c flux-postbuild-substitution, 3d keycloak-client-secret-reconciler, 3e
bulk-tier-distinct-from-replicated. Three near-identical 12-line rationales, three
hardcoded check.sh paths, three copies of the same rc 0/3/* case block — and worst, a
mechanism that failed SILENTLY, because whoever added the NEXT whole-repo invariant had
to REMEMBER to write a stage, and if they forgot the check ran only when some unrelated
requirement happened to be touched.
A test now DECLARES the scope of its invariant and the runner enforces it:
metadata:
annotations:
conformance.home.k3s/scope: "whole-repo"
* conformance/lib/common.sh conf_dirs_for_scope(s) resolves the annotation. Carries the
general rationale, once, instead of per stage.
* conformance/run.sh --include-scope SCOPE unions declaring tests into select_dirs,
still bounded by --layer. New --print-selection resolves the
selection and exits, running nothing.
* lib/run_l1_offline.py --unwired-scope: a SKIP of a declaring test exits 3, not 0.
--summary-out: one step-summary line per executed check.
* ci/l0.sh Stage 3b gains --include-scope whole-repo and an rc-3 arm.
Stages 3c/3d/3e DELETED (-150 lines).
* ci/l1.sh, ci/conformance.sh pass --include-scope too, so the next whole-repo invariant
at ANY layer needs only the annotation.
rc 3 SEMANTICS PRESERVED EXACTLY. A whole-repo check reporting "nothing to audit" is
reporting that the tree it audits has VANISHED. The deleted stages called that "not a
pass" and set the gate's rc=3; the runner now returns 3 and ci/l0.sh maps it to rc=3.
A missing check file still degrades to not-green, never to silence.
THE REASONING WAS RELOCATED, NOT DELETED. Each stage's incident narrative moved into the
header of the test it describes, beside its scope annotation: the Cilium k8sServiceHost
empty-substitution CNI outage (2026-09-01), 12 unusable Keycloak clients behind a green
cluster (2026-09-06), and a multi-TB bulk volume landing on the 3-replica tier.
AUDITED ALL 13 EXISTING l0-static TESTS, individually. 10 declare whole-repo scope; 3 are
DELIBERATELY left requirement-scoped and say so in their own headers:
* placeholder-guard-coupling — inputs are bootstrap/ + clusters/, both already mapped to
a requirement it declares. Scoping cannot hide a breaking change.
* dev-nodes-provisioned-as-code — inputs are infra/ and nothing else.
* spec-immutability-enforced — inputs are ci/ and the read-only spec repo.
The latter two were nonetheless under-gated because the PATH MAP was incomplete, which is
the right place to fix a path-scoped invariant: infra/* -> R-ENV-01 added, and R-TEST-06
added to .gitea/*|ci/* (it is no longer an uncovered ID — spec-immutability-enforced
carries the label, so attributing it no longer false-blocks the coverage gate).
NEW conformance/tests/l0-static/whole-repo-invariants-wired (R-TEST-03) keeps the
declarative mechanism honest for ALL declaring tests at once, replacing the three tests'
individual "ci/l0.sh greps my own check.sh path" self-assertions. It proves the union
EMPIRICALLY: with a requirement filter matching no test the L0 selection is empty, and
with --include-scope it is every declaring test; a scope-declared synthetic SKIP exits 3
while an undeclared one exits 0; and a ci/*.sh that hardcodes a check.sh path must belong
to a test that also declares the scope, so the bespoke pattern cannot creep back.
TASK 2 — a changed test attributes the requirements it CERTIFIES.
ci/touched-requirements.sh gains detection rule 3: a change anywhere under
conformance/tests/<test>/ attributes that test's own conformance.home.k3s/R-* labels, read
from its chainsaw-test.yaml. The content scan could not close this — it reads only
added/removed lines, so it sees a change to the LABEL BLOCK but not to the test BODY,
which is exactly the case that matters. Labels are read from HEAD or, failing that, from
the BASE, so DELETING a test still attributes what it used to certify; otherwise removing
the only verifier of a requirement is the cheapest way to make the gate stop checking it.
Whole-line `#` comments are dropped first and *.md is untouched, honouring the existing
"reference, not declaration" rules.
Both changes are fail-closed: every one of them can only ADD tests or requirements to a
run, never remove one.
TESTS: new ci/tests/touched-requirements-test-attribution.test.sh (15 assertions) covers
rule 3 — body-only edit, nested-fixture walk-up, test deletion, header-comment R-IDs not
attributed, non-test paths unaffected, and both new path-map entries. The two existing
suites still pass (39 assertions). `make -C ci test` runs all three.
Co-Authored-By: Claude Opus 5 <[email protected]>
77 lines
4.6 KiB
YAML
77 lines
4.6 KiB
YAML
# =============================================================================
|
|
# L0 STATIC — certificate lifecycle needs no manual step (R-TLS-02) [EXECUTABLE]
|
|
# Catalog: docs/14 L0 row ("Pre-apply, in CI") — runs WITHOUT a cluster.
|
|
# Spec: docs/00 R-TLS-02 ("Certificates MUST be automatically issued, renewed, and
|
|
# revoked without manual steps"); mechanism in docs/08 + ADR-0006.
|
|
#
|
|
# R-TLS-02 is one adverbial clause plus three runtime verbs. This test asserts the
|
|
# clause — "without manual steps" — which in a GitOps platform is a property of the
|
|
# REPOSITORY: a human step in the certificate path leaves evidence in git (committed
|
|
# cert material, a Gateway serving a Secret nothing declares, an issuer with no
|
|
# automated solver, a credential never delivered, auto-approval switched off, or CRs
|
|
# nothing reconciles). The three verbs are observed by the companion L2 test.
|
|
#
|
|
# ENVIRONMENT-AGNOSTIC (R-ENV-02): the issuer a Certificate names is `${ACME_CLUSTER_ISSUER}`,
|
|
# so the check resolves it against the BASE cluster-vars default AND every overlay's value and
|
|
# requires each resolved issuer to exist. dev's issuer and prod's issuer are both verified from
|
|
# one authored assertion, with no hostname, address or environment name written down.
|
|
#
|
|
# GIVEN the repository as git tracks it,
|
|
# WHEN every serving-TLS reference, Certificate, Issuer and the cert-manager release
|
|
# is inspected offline,
|
|
# THEN every Gateway listener that terminates TLS serves a Secret a tracked Certificate
|
|
# produces; no certificate material is committed anywhere; every Certificate's
|
|
# issuer resolves — in EVERY environment — to a tracked ACME issuer with an
|
|
# automated dns01/http01 solver whose credential is SOPS-delivered from git;
|
|
# cert-manager's automatic request approval is not disabled; and every one of
|
|
# those objects is rendered by a Flux Kustomization, so nothing in the chain
|
|
# depends on a human running kubectl.
|
|
#
|
|
# STATUS: EXECUTABLE. `check.sh` is a pure offline assertion script (git + PyYAML, no
|
|
# cluster, no network); conformance/run.sh --layer l0 and ci/l0.sh run it directly, and
|
|
# this Chainsaw Test wraps the SAME script.
|
|
#
|
|
# KNOWN, DELIBERATE GAPS (named in check.sh's header too — this test claims NONE of them):
|
|
# * ISSUED / RENEWED as runtime events: L2 (l2-behavioral/cert-lifecycle-automated).
|
|
# * REVOKED: not proven at any layer today. cert-manager performs no ACME revocation,
|
|
# and the spec's own reading (docs/08: "removing/rotating a certificate is a
|
|
# declarative change") needs `enableCertificateOwnerRef`, which the tracked
|
|
# cert-manager HelmRelease does not set — so a removed Certificate leaves its
|
|
# serving Secret behind. The L2 test asserts the withdrawal behaviour and is
|
|
# EXPECTED TO FAIL until that knob is set; escalated, not softened (R-TEST-06).
|
|
# * That the live cluster is serving the tracked Certificate (cluster state).
|
|
# =============================================================================
|
|
apiVersion: chainsaw.kyverno.io/v1alpha1
|
|
kind: Test
|
|
metadata:
|
|
name: tls-lifecycle-automated
|
|
labels:
|
|
conformance.home.k3s/R-TLS-02: "true"
|
|
annotations:
|
|
conformance.home.k3s/requirements: "R-TLS-02"
|
|
conformance.home.k3s/layer: "L0"
|
|
# WHOLE-REPO SCOPE. Universally quantified over tracked YAML: it inventories every
|
|
# cert-manager Certificate/Issuer and every Gateway TLS listener wherever they are
|
|
# authored, and cross-checks each against the issuers and cluster-vars knobs that exist.
|
|
# A new HTTPRoute/Gateway or a hand-rolled Certificate under apps/ or platform/<x>/
|
|
# attributes no requirement, so requirement-scoped selection would skip the check that
|
|
# would have caught a listener whose secret nothing ever issues.
|
|
conformance.home.k3s/scope: "whole-repo"
|
|
conformance.home.k3s/safety-critical: "false"
|
|
conformance.home.k3s/executable: "true"
|
|
conformance.home.k3s/intent: >-
|
|
Given the tracked tree, when the certificate path is inspected offline, then no
|
|
manual step exists anywhere in it: serving Secrets are cert-manager-produced, no
|
|
cert material is committed, every environment's issuer is a tracked ACME issuer
|
|
with an automated solver and a git-delivered credential, auto-approval is on, and
|
|
the whole chain is Flux-reconciled.
|
|
spec:
|
|
steps:
|
|
- name: then-no-manual-step-exists-in-the-certificate-path
|
|
description: >-
|
|
Run the offline assertion script over the tracked tree (same script ci/l0.sh
|
|
and conformance/run.sh --layer l0 execute).
|
|
try:
|
|
- script:
|
|
content: bash ./check.sh
|