docs(ci): the wiring comment named a secret Gitea cannot accept #21

Merged
jakman85 merged 1 commits from fix/gitea-settings-comment-names-impossible-secret into main 2026-09-30 03:22:06 +00:00
Owner

ci/gitea-settings.sh told the reader to "create a Gitea repo secret GITEA_SETTINGS_TOKEN".
That instruction is impossible to follow — Gitea reserves the GITEA_ prefix for secret names
and rejects the PUT with HTTP 400 {"message":"invalid secret name"}.

Third file carrying the same defect: fixed in the script's own logic in #15, in
infra/gitea/README.md in #19, and here. Found by an agent reading the file rather than trusting
my description of it.

A comment that instructs an impossible action isn't cosmetic — this exact wrong name is why the
drift detector sat inert
while a token existed and no secret did.

Now names SETTINGS_API_TOKEN, and states explicitly that GITEA_SETTINGS_TOKEN remains honoured
only as a local-run env var: it can never be the CI wiring, because the secret that would feed
it cannot be created at all.

Comment-only; no behaviour change. Gate: rc 3 / UNDETERMINED naming gitea-settings as unrun
(no token locally — the designed skip, tolerated by gate.yml); lint, l0, render-golden and l1 all
green, nothing failed.

Co-Authored-By: Claude Opus 5 (1M context) [email protected]

🤖 Generated with Claude Code

`ci/gitea-settings.sh` told the reader to *"create a Gitea repo secret `GITEA_SETTINGS_TOKEN`"*. That instruction is **impossible to follow** — Gitea reserves the `GITEA_` prefix for secret names and rejects the PUT with `HTTP 400 {"message":"invalid secret name"}`. Third file carrying the same defect: fixed in the script's own logic in #15, in `infra/gitea/README.md` in #19, and here. Found by an agent reading the file rather than trusting my description of it. A comment that instructs an impossible action isn't cosmetic — **this exact wrong name is why the drift detector sat inert** while a token existed and no secret did. Now names `SETTINGS_API_TOKEN`, and states explicitly that `GITEA_SETTINGS_TOKEN` remains honoured **only** as a local-run env var: it can never be the CI wiring, because the secret that would feed it cannot be created at all. Comment-only; no behaviour change. Gate: `rc 3 / UNDETERMINED` naming `gitea-settings` as unrun (no token locally — the designed skip, tolerated by `gate.yml`); lint, l0, render-golden and l1 all green, nothing failed. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]> 🤖 Generated with [Claude Code](https://claude.com/claude-code)
gitea-admin added 1 commit 2026-09-30 00:32:01 +00:00
docs(ci): the wiring comment named a secret Gitea cannot accept
gate / gate (pull_request) Successful in 1m36s
gate / conformance (pull_request) Has been skipped
e993d0f7d1
ci/gitea-settings.sh told the reader to "create a Gitea repo secret
GITEA_SETTINGS_TOKEN". That instruction is IMPOSSIBLE to follow: Gitea reserves the
GITEA_ prefix for secret names and rejects the PUT with HTTP 400 "invalid secret name".

Same defect as the one fixed in PR #15 and in the README in PR #19 -- this was the third
file carrying it, found by an agent reading the file rather than trusting my description
of it. A comment that instructs an impossible action is not cosmetic: this exact wrong
name is why the drift detector sat inert while a token existed and no secret did.

Now names SETTINGS_API_TOKEN, and states explicitly that GITEA_SETTINGS_TOKEN remains
honoured ONLY as a local-run env var -- it can never be the CI wiring, because the secret
that would feed it cannot exist.

Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
jakman85 approved these changes 2026-09-30 03:22:03 +00:00
jakman85 merged commit cadf64a514 into main 2026-09-30 03:22:06 +00:00
Sign in to join this conversation.
No Reviewers
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: Home-Network/home-network-k3s-impl#21